Implement WebPushProvider.unregister() in Chromium.

chrome/browser/services/gcm/push_messaging_service_impl.h

Index: chrome/browser/services/gcm/push_messaging_service_impl.h
diff --git a/chrome/browser/services/gcm/push_messaging_service_impl.h b/chrome/browser/services/gcm/push_messaging_service_impl.h
index 8597eb63e69c2aa6b5b4f404326ce71ed62aff6b..16cea423a205916f903e67ae41808d312c0b2c90 100644
--- a/chrome/browser/services/gcm/push_messaging_service_impl.h
+++ b/chrome/browser/services/gcm/push_messaging_service_impl.h
@@ -73,6 +73,10 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
   blink::WebPushPermissionStatus GetPermissionStatus(
       const GURL& requesting_origin,
       const GURL& embedding_origin) override;
+  void Unregister(

[johnme, 2014/12/15 12:07:16]

Similarly here, please move this above the GetPermissionStatus methods (keeping
to the same Register,Unregister,GetRegistration,HasPermission,Delivery order).

+      const GURL& requesting_origin,
+      int64 service_worker_registration_id,
+      const content::PushMessagingService::UnregisterCallback&) override;
 
   void SetProfileForTesting(Profile* profile);
 
@@ -100,11 +104,11 @@ class PushMessagingServiceImpl : public content::PushMessagingService,
       const content::PushMessagingService::RegisterCallback& callback,
       bool allow);
 
-  // TODO(mvanouwerkerk): this will need to be extended and move to the
-  // PushMessagingService interface later.
-  void Unregister(const PushMessagingApplicationId& application_id);
+  void Unregister(const PushMessagingApplicationId& application_id,
+                  const content::PushMessagingService::UnregisterCallback&);
 
-  void DidUnregister(GCMClient::Result result);
+  void DidUnregister(const content::PushMessagingService::UnregisterCallback&,
+                     GCMClient::Result result);
 
   // Helper method that checks if a given origin is allowed to use Push.
   bool HasPermission(const GURL& origin);