Implement WebPushProvider.unregister() in Chromium.

content/child/push_messaging/push_provider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_PUSH_MESSAGING_PUSH_MANAGER_H_
 #define CONTENT_CHILD_PUSH_MESSAGING_PUSH_MANAGER_H_
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
@@ skipping 15 matching lines @@
   // The |thread_safe_sender| and |push_dispatcher| are used if calling this
   // leads to construction.
   static PushProvider* ThreadSpecificInstance(
       ThreadSafeSender* thread_safe_sender,
       PushDispatcher* push_dispatcher);
 
   // WorkerTaskRunner::Observer implementation.
   void OnWorkerRunLoopStopped() override;
 
   // blink::WebPushProvider implementation.
-  void registerPushMessaging(blink::WebServiceWorkerRegistration*,
-                             blink::WebPushRegistrationCallbacks*) override;
-  void getPermissionStatus(blink::WebServiceWorkerRegistration*,
-                           blink::WebPushPermissionStatusCallbacks*) override;
+  virtual void registerPushMessaging(blink::WebServiceWorkerRegistration*,
+                                     blink::WebPushRegistrationCallbacks*);
+  virtual void getPermissionStatus(blink::WebServiceWorkerRegistration*,
+                                   blink::WebPushPermissionStatusCallbacks*);
+  virtual void unregister(blink::WebServiceWorkerRegistration*,

[johnme, 2014/12/15 12:07:16]

Ditto method order. And below.

+                          blink::WebPushUnregisterCallbacks*);
 
   // Called by the PushDispatcher.
   bool OnMessageReceived(const IPC::Message& message);
 
  private:
   PushProvider(ThreadSafeSender* thread_safe_sender,
                PushDispatcher* push_dispatcher);
 
   // IPC message handlers.
   void OnRegisterFromWorkerSuccess(int request_id,
                                    const GURL& endpoint,
                                    const std::string& registration_id);
   void OnRegisterFromWorkerError(int request_id, PushRegistrationStatus status);
   void OnGetPermissionStatusSuccess(int request_id,
                                     blink::WebPushPermissionStatus status);
   void OnGetPermissionStatusError(int request_id);
+  void OnUnregisterResponse(int request_id, bool unregistered);

[Michael van Ouwerkerk, 2014/12/15 12:29:14]

I'd like more clarity on the meaning of this boolean before committing. Is it
"operation success" or "registration state is unregistered"? When unregistering
the same registration twice, the first meaning could be false and the second
true, for the same end result.

[Michael van Ouwerkerk, 2014/12/16 11:36:51]

From [1] it seems your intent is to signal whether the operation succeeded, not
whether the current state is unregistered. Please rename |unregistered| to
|success|.

[1] https://github.com/w3c/push-api/pull/97#issuecomment-67039200

 
   scoped_refptr<ThreadSafeSender> thread_safe_sender_;
   scoped_refptr<PushDispatcher> push_dispatcher_;
 
   // Stores the registration callbacks with their request ids. This class owns
   // the callbacks.
   std::map<int, blink::WebPushRegistrationCallbacks*> registration_callbacks_;
 
   // Stores the permission status callbacks with their request ids. This class
   // owns the callbacks.
   std::map<int, blink::WebPushPermissionStatusCallbacks*>
       permission_status_callbacks_;
 
+  // Stores the unregistration callbacks with their request ids. This class owns
+  // the callbacks.
+  std::map<int, blink::WebPushUnregisterCallbacks*> unregister_callbacks_;
+
   DISALLOW_COPY_AND_ASSIGN(PushProvider);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_PUSH_MESSAGING_PUSH_MANAGER_H_