Implement WebPushProvider.unregister() in Chromium.

chrome/browser/services/gcm/push_messaging_service_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 #define CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "components/gcm_driver/gcm_app_handler.h"
@@ skipping 55 matching lines @@
       const content::PushMessagingService::RegisterCallback& callback) override;
   // TODO(mvanouwerkerk): Delete once the Push API flows through platform.
   // https://crbug.com/389194
   blink::WebPushPermissionStatus GetPermissionStatus(
       const GURL& requesting_origin,
       int renderer_id,
       int render_frame_id) override;
   blink::WebPushPermissionStatus GetPermissionStatus(
       const GURL& requesting_origin,
       const GURL& embedding_origin) override;
+  void Unregister(

[johnme, 2014/12/15 12:07:16]

Similarly here, please move this above the GetPermissionStatus methods (keeping
to the same Register,Unregister,GetRegistration,HasPermission,Delivery order).

+      const GURL& requesting_origin,
+      int64 service_worker_registration_id,
+      const content::PushMessagingService::UnregisterCallback&) override;
 
   void SetProfileForTesting(Profile* profile);
 
  private:
   void IncreasePushRegistrationCount(int add);
   void DecreasePushRegistrationCount(int subtract);
 
   void DeliverMessageCallback(const PushMessagingApplicationId& application_id,
                               const GCMClient::IncomingMessage& message,
                               content::PushDeliveryStatus status);
 
   void RegisterEnd(
       const content::PushMessagingService::RegisterCallback& callback,
       const std::string& registration_id,
       content::PushRegistrationStatus status);
 
   void DidRegister(
       const content::PushMessagingService::RegisterCallback& callback,
       const std::string& registration_id,
       GCMClient::Result result);
 
   void DidRequestPermission(
       const PushMessagingApplicationId& application_id,
       const std::string& sender_id,
       const content::PushMessagingService::RegisterCallback& callback,
       bool allow);
 
-  // TODO(mvanouwerkerk): this will need to be extended and move to the
-  // PushMessagingService interface later.
-  void Unregister(const PushMessagingApplicationId& application_id);
+  void Unregister(const PushMessagingApplicationId& application_id,
+                  const content::PushMessagingService::UnregisterCallback&);
 
-  void DidUnregister(GCMClient::Result result);
+  void DidUnregister(const content::PushMessagingService::UnregisterCallback&,
+                     GCMClient::Result result);
 
   // Helper method that checks if a given origin is allowed to use Push.
   bool HasPermission(const GURL& origin);
 
   // Adds this service as an app handler to the GCMDriver if it has not been
   // added yet.
   void AddAppHandlerIfNecessary();
 
   GCMProfileService* gcm_profile_service_;  // It owns us.
 
   Profile* profile_;  // It owns our owner.
 
   int push_registration_count_;
 
   base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl);
 };
 
 }  // namespace gcm
 
 #endif  // CHROME_BROWSER_SERVICES_GCM_PUSH_MESSAGING_SERVICE_IMPL_H_