Use SuppressFBWarnings to suppress findbugs warnings

Use SuppressFBWarnings to suppress findbugs warnings

This has several benefits:
Makes the warning obvious at the place of the problem
Makes suppressing the warnings the same as suppressing compiler and lint warnings
Makes supporting findbugs as part of the build easier

TBR=rmcilroy, mef, boliu

BUG=431826
Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
Cr-Commit-Position: refs/heads/master@{#311402}

Committed: https://crrev.com/7ff0672b2a8c73be5a0164a04bc9c53f64f4b138
Cr-Commit-Position: refs/heads/master@{#311596}

[cjhopman, 2014-12-12 01:59:42]

Patchset #4 (id:60001) has been deleted

[cjhopman, 2014-12-12 01:59:48]

Patchset #3 (id:40001) has been deleted

[cjhopman, 2014-12-12 01:59:53]

Patchset #2 (id:20001) has been deleted

[cjhopman, 2014-12-12 01:59:59]

Patchset #1 (id:1) has been deleted

[cjhopman, 2014-12-16 19:29:54]

cjhopman@chromium.org changed reviewers:
+ aurimas@chromium.org

[cjhopman, 2014-12-16 19:29:55]

aurimas: *

[aurimas (slooooooooow), 2015-01-06 20:57:50]

lgtm

[newt (away), 2015-01-13 01:35:50]

newt@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-01-13 01:35:50]

ping ping ping :)

[newt (away), 2015-01-13 01:36:04]

On 2015/01/13 01:35:50, newt wrote:
> ping ping ping :)

Can I haz?

[cjhopman, 2015-01-13 03:19:48]

cjhopman@chromium.org changed reviewers:
+ tedchoc@chromium.org

[cjhopman, 2015-01-13 03:19:49]

tedchoc: *

[Ted C, 2015-01-13 18:24:41]

lgtm

[cjhopman, 2015-01-14 00:46:32]

cjhopman@chromium.org changed reviewers:
+ boliu@chromium.org, mef@chromium.org, rmcilroy@chromium.org

[cjhopman, 2015-01-14 00:46:33]

TBRed:
rmcilroy: base/*
boliu: android_webview/*
mef: components/cronet/*

[cjhopman, 2015-01-14 00:47:46]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2015-01-14 00:48:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793203002/250001

[commit-bot: I haz the power, 2015-01-14 01:00:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 01:00:11]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[cjhopman, 2015-01-14 01:00:50]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2015-01-14 01:01:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793203002/250001

[commit-bot: I haz the power, 2015-01-14 01:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 01:31:54]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[cjhopman, 2015-01-14 02:11:36]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2015-01-14 02:12:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793203002/270001

[commit-bot: I haz the power, 2015-01-14 02:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 02:15:55]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[cjhopman, 2015-01-14 02:28:43]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2015-01-14 02:30:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793203002/290001

[commit-bot: I haz the power, 2015-01-14 03:34:26]

Committed patchset #12 (id:290001)

[commit-bot: I haz the power, 2015-01-14 03:35:41]

Patchset 12 (id:??) landed as
https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
Cr-Commit-Position: refs/heads/master@{#311402}

[Ken Rockot(use gerrit already), 2015-01-14 06:00:06]

A revert of this CL (patchset #12 id:290001) has been created in
https://codereview.chromium.org/797403005/ by rockot@chromium.org.

The reason for reverting is: This is consistently causing bot failures, starting
with
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28d...
.

[mef, 2015-01-14 16:04:50]

On 2015/01/14 06:00:06, Ken Rockot wrote:
> A revert of this CL (patchset #12 id:290001) has been created in
> https://codereview.chromium.org/797403005/ by mailto:rockot@chromium.org.
> 
> The reason for reverting is: This is consistently causing bot failures,
starting
> with
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28d...
> .

c/cronet/* look ok.

Could buildbot failure be result of stale cronet.jar being processed by
findbugs?

[cjhopman, 2015-01-14 22:42:26]

On 2015/01/14 16:04:50, mef wrote:
> On 2015/01/14 06:00:06, Ken Rockot wrote:
> > A revert of this CL (patchset #12 id:290001) has been created in
> > https://codereview.chromium.org/797403005/ by mailto:rockot@chromium.org.
> > 
> > The reason for reverting is: This is consistently causing bot failures,
> starting
> > with
> >
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28d...
> > .
> 
> c/cronet/* look ok.
> 
> Could buildbot failure be result of stale cronet.jar being processed by
> findbugs?

Yeah, I expect that's the case (it looks like this bot isn't even building
cronet...).

I'll land this with a landmine.

[cjhopman, 2015-01-14 22:42:32]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2015-01-14 22:42:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/793203002/310001

[commit-bot: I haz the power, 2015-01-15 01:00:20]

Committed patchset #13 (id:310001)

[commit-bot: I haz the power, 2015-01-15 01:01:40]

Patchset 13 (id:??) landed as
https://crrev.com/7ff0672b2a8c73be5a0164a04bc9c53f64f4b138
Cr-Commit-Position: refs/heads/master@{#311596}

[Anand Mistry (off Chromium), 2015-01-15 02:27:27]

On 2015/01/15 01:01:40, I haz the power (commit-bot) wrote:
> Patchset 13 (id:??) landed as
> https://crrev.com/7ff0672b2a8c73be5a0164a04bc9c53f64f4b138
> Cr-Commit-Position: refs/heads/master@{#311596}

This appears to be causing failures in the findbugs step of the the Android
builders.
https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28d...

[cjhopman, 2015-01-15 02:28:40]

the land mine exposed a bug in the build configuration.

https://codereview.chromium.org/840343006/