Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java

Issue 793203002: Use SuppressFBWarnings to suppress findbugs warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + landmine Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
index bba6d124bb025374d1bab5bd2c9442bc95a2707a..59fd08d6490d2c242e1db726882c15b009f2d9fb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProvider.java
@@ -33,6 +33,7 @@ import org.chromium.base.CalledByNative;
import org.chromium.base.CalledByNativeUnchecked;
import org.chromium.base.ThreadUtils;
import org.chromium.base.VisibleForTesting;
+import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.chrome.browser.database.SQLiteCursor;
import org.chromium.sync.notifier.SyncStatusHelper;
@@ -386,6 +387,7 @@ public class ChromeBrowserProvider extends ContentProvider {
}
@Override
+ @SuppressFBWarnings("SF_SWITCH_FALLTHROUGH")
public Uri insert(Uri uri, ContentValues values) {
if (!canHandleContentProviderApiCall() || !hasWriteAccess()) return null;
@@ -832,6 +834,7 @@ public class ChromeBrowserProvider extends ContentProvider {
/**
* @return The bookmark favicon, if any.
*/
+ @SuppressFBWarnings("EI_EXPOSE_REP")
public byte[] favicon() {
return mFavicon;
}
@@ -839,6 +842,7 @@ public class ChromeBrowserProvider extends ContentProvider {
/**
* @return The bookmark thumbnail, if any.
*/
+ @SuppressFBWarnings("EI_EXPOSE_REP")
public byte[] thumbnail() {
return mThumbnail;
}
@@ -907,11 +911,13 @@ public class ChromeBrowserProvider extends ContentProvider {
}
@VisibleForTesting
+ @SuppressFBWarnings("EI_EXPOSE_REP2")
public void setFavicon(byte[] favicon) {
mFavicon = favicon;
}
@VisibleForTesting
+ @SuppressFBWarnings("EI_EXPOSE_REP2")
public void setThumbnail(byte[] thumbnail) {
mThumbnail = thumbnail;
}
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698