Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2349)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java

Issue 793203002: Use SuppressFBWarnings to suppress findbugs warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + landmine Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java
index 3edf1d355e2c02bf3f70c4cba7b729c34262e04a..c1c5249805de343f769903a53bc3175861c00dd8 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java
@@ -11,6 +11,7 @@ import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;
import org.chromium.android_webview.AwContents;
import org.chromium.base.ThreadUtils;
+import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils;
@@ -120,6 +121,7 @@ public class ArchiveTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView"})
+ @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")
public void testExplicitBadPath() throws Throwable {
final String path = new File("/foo/bar/baz.mht").getAbsolutePath();
deleteFile(path);
@@ -132,6 +134,7 @@ public class ArchiveTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView"})
+ @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")
public void testAutoBadPath() throws Throwable {
final String path = new File("/foo/bar/").getAbsolutePath();
deleteFile(path);

Powered by Google App Engine
This is Rietveld 408576698