Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 792803008: cc: Split out BeginFrame needed verse proactive for commits. (Closed)

Created:
6 years ago by mithro-old
Modified:
5 years, 8 months ago
Reviewers:
sunnyps, brianderson
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Split out BeginFrame needed verse proactive for commits. In "cc: Only send a BeginMainFrame inside an BeginImplFrame." https://codereview.chromium.org/798323003/ a commit can only occur inside an impl frame - this means BeginFrames are *needed* if we want to commit. We also want to proactively request BeginFrames if a commit is pending (for performance), but it is not actually required. BUG=346230 Committed: https://crrev.com/102333b3fdd6e288f1e80f77d745269b405d38b4 Cr-Commit-Position: refs/heads/master@{#324356}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase onto master. #

Patch Set 3 : Reworked patch now Sunny has landed the webview refactor. #

Patch Set 4 : Renaming methods to be clearer about intentions. #

Total comments: 2

Patch Set 5 : Rebase onto master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M cc/scheduler/scheduler_state_machine.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 2 3 4 5 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 21 (3 generated)
mithro-old
Hi, A small fix and test for a case missed in https://codereview.chromium.org/798323003/ Tim
6 years ago (2014-12-19 02:29:24 UTC) #2
mithro-old
On 2014/12/19 02:29:24, mithro wrote: > Hi, > > A small fix and test for ...
6 years ago (2014-12-19 04:44:38 UTC) #3
brianderson
https://codereview.chromium.org/792803008/diff/1/cc/scheduler/scheduler_state_machine.cc File cc/scheduler/scheduler_state_machine.cc (left): https://codereview.chromium.org/792803008/diff/1/cc/scheduler/scheduler_state_machine.cc#oldcode441 cc/scheduler/scheduler_state_machine.cc:441: BeginFrameNeeded()) The check for BeginFrameNeeded is so we can ...
6 years ago (2014-12-19 23:34:06 UTC) #4
sunnyps
https://codereview.chromium.org/792803008/diff/1/cc/scheduler/scheduler_state_machine.cc File cc/scheduler/scheduler_state_machine.cc (right): https://codereview.chromium.org/792803008/diff/1/cc/scheduler/scheduler_state_machine.cc#newcode704 cc/scheduler/scheduler_state_machine.cc:704: BeginFrameNeededForChildren() || ProactiveBeginFrameWanted()); OR needs_commit_ here. https://codereview.chromium.org/792803008/diff/1/cc/scheduler/scheduler_state_machine.cc#newcode760 cc/scheduler/scheduler_state_machine.cc:760: return ...
5 years, 9 months ago (2015-03-05 00:19:48 UTC) #5
mithro-old
FYI - the tests I'm trying to make pass in https://codereview.chromium.org/787763006/ are below; ---- C ...
5 years, 9 months ago (2015-03-11 23:45:06 UTC) #6
brianderson
Tim, any idea how to work around the WebView monotonicity issues? It might be a ...
5 years, 9 months ago (2015-03-14 01:05:28 UTC) #7
mithro-old
Hi everyone, This patch fixes a small "schematic" issue with the way commits and BeginFrame ...
5 years, 8 months ago (2015-04-02 05:42:02 UTC) #8
mithro-old
That should have been "semantic" not "schematic".
5 years, 8 months ago (2015-04-02 05:42:40 UTC) #9
brianderson
Are any tests affected by this change?
5 years, 8 months ago (2015-04-07 03:29:52 UTC) #10
mithro-old
On 2015/04/07 03:29:52, brianderson wrote: > Are any tests affected by this change? This does ...
5 years, 8 months ago (2015-04-07 07:04:31 UTC) #11
sunnyps
I don't understand why this change is being made. It's really confusing to have to ...
5 years, 8 months ago (2015-04-07 23:24:27 UTC) #12
mithro-old
On 2015/04/07 at 23:24:27, sunnyps wrote: > I don't understand why this change is being ...
5 years, 8 months ago (2015-04-07 23:50:44 UTC) #13
sunnyps
I guess what I'm trying to say is that the proactive vs non-proactive distinction existed ...
5 years, 8 months ago (2015-04-08 00:03:29 UTC) #14
brianderson
lgtm. I like keeping the distinction between required vs. nice-to-have BeginFrames so that the intention ...
5 years, 8 months ago (2015-04-08 01:46:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/792803008/80001
5 years, 8 months ago (2015-04-09 00:16:34 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-09 03:56:25 UTC) #19
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/102333b3fdd6e288f1e80f77d745269b405d38b4 Cr-Commit-Position: refs/heads/master@{#324356}
5 years, 8 months ago (2015-04-09 03:57:15 UTC) #20
mithro-old
5 years, 8 months ago (2015-04-09 04:08:08 UTC) #21
Message was sent while issue was closed.
https://codereview.chromium.org/792803008/diff/60001/cc/scheduler/scheduler_s...
File cc/scheduler/scheduler_state_machine.cc (right):

https://codereview.chromium.org/792803008/diff/60001/cc/scheduler/scheduler_s...
cc/scheduler/scheduler_state_machine.cc:727: return
(BeginFrameRequiredForAction() || BeginFrameRequiredForChildren() ||
On 2015/04/08 01:46:56, brianderson wrote:
> Should we put BeginFrameRequiredForChildren above the
> HasInitializedOutputSurface check? None of our BeginFrameSources are  tied to
> the existence of an OutputSurface anymore.

I'll do that in a different CL.

Powered by Google App Engine
This is Rietveld 408576698