Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 791723003: Use of the playback time in the MSE garbage collection. (Closed)

Created:
6 years ago by kjoswiak
Modified:
6 years ago
Reviewers:
damienv1, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use of the playback time in the MSE garbage collection. The MSE spec clearly mentions what should be the state of the media element based on the buffered ranges (see MSE spec 2.4.4 SourceBuffer Monitoring). Since there is a latency between the read position in the source buffer stream and the playback position, the MSE garbage collection must be adjusted so as to not remove the playback position from the buffered ranges. Conflicts: content/renderer/media/webmediaplayer_impl.cc media/filters/chunk_demuxer.cc media/filters/source_buffer_stream.cc BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.h View 3 chunks +10 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M media/filters/source_buffer_range.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/source_buffer_range.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M media/filters/source_buffer_stream.h View 2 chunks +6 lines, -0 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 5 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjoswiak
Ported from Chromecast codebase, a more up-to-date version of https://codereview.chromium.org/341083004/
6 years ago (2014-12-09 20:58:21 UTC) #1
DaleCurtis
6 years ago (2014-12-09 21:15:06 UTC) #4
damienv1
As discussed in https://codereview.chromium.org/341083004/ with Aaron, we can have a better design by moving the ...
6 years ago (2014-12-11 17:46:26 UTC) #5
kjoswiak
6 years ago (2014-12-11 23:25:26 UTC) #6
After giving this some thought, I am combining this CL with another I have open,
https://codereview.chromium.org/789983003/. This other CL provides an alternate
path for GC to trigger that is more in line with MSE spec, enabling removing GC
from internal append loop. However, implementing that CL doesn't make sense
until we tone down GC aggressiveness (this CL), and as noted this CL can be
simplified by not calling GC during append loop, and not having to track media
time in SourceBufferStream.

New CL: https://codereview.chromium.org/794343003/

Powered by Google App Engine
This is Rietveld 408576698