Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 789983003: Implement evictFrames() to support MSE's coded frame eviction algorithm. (Closed)

Created:
6 years ago by kjoswiak
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement evictFrames() to support MSE's coded frame eviction algorithm. s/WebKit/Blink/ Implemented WebSourceBufferImpl::evictFrames() to call SourceBuffer::GarbageCollectIfNeeded()

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M media/blink/websourcebuffer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/websourcebuffer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.h View 2 chunks +9 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 4 chunks +33 lines, -0 lines 3 comments Download
M media/filters/source_buffer_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kjoswiak
Codependent on https://codereview.chromium.org/785343002/
6 years ago (2014-12-09 22:51:07 UTC) #1
philipj_slow
https://codereview.chromium.org/789983003/diff/1/media/filters/chunk_demuxer.cc File media/filters/chunk_demuxer.cc (right): https://codereview.chromium.org/789983003/diff/1/media/filters/chunk_demuxer.cc#newcode389 media/filters/chunk_demuxer.cc:389: for (TextStreamMap::iterator itr = text_stream_map_.begin(); If C++11 range-based for ...
6 years ago (2014-12-10 09:26:08 UTC) #4
philipj_slow
s/WebKit/Blink/ in the title/description. Something more descriptive like "Implement evictFrames() to support MSE's coded frame ...
6 years ago (2014-12-10 09:31:02 UTC) #5
kjoswiak
https://codereview.chromium.org/789983003/diff/1/media/filters/chunk_demuxer.cc File media/filters/chunk_demuxer.cc (right): https://codereview.chromium.org/789983003/diff/1/media/filters/chunk_demuxer.cc#newcode389 media/filters/chunk_demuxer.cc:389: for (TextStreamMap::iterator itr = text_stream_map_.begin(); On 2014/12/10 09:26:08, philipj ...
6 years ago (2014-12-10 19:35:28 UTC) #7
philipj_slow
https://codereview.chromium.org/789983003/diff/1/media/filters/chunk_demuxer.cc File media/filters/chunk_demuxer.cc (right): https://codereview.chromium.org/789983003/diff/1/media/filters/chunk_demuxer.cc#newcode389 media/filters/chunk_demuxer.cc:389: for (TextStreamMap::iterator itr = text_stream_map_.begin(); On 2014/12/10 19:35:28, kjoswiak ...
6 years ago (2014-12-10 19:39:56 UTC) #8
kjoswiak
6 years ago (2014-12-11 23:28:26 UTC) #9
Combined with another CL to create https://codereview.chromium.org/794343003/

Powered by Google App Engine
This is Rietveld 408576698