Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 790183002: Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpda... (Closed)

Created:
6 years ago by earthdok
Modified:
6 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros. (patchset #7 id:120001 of https://codereview.chromium.org/738843002/) Reason for revert: Speculative revert to see if this is the cause of issue 440063. BUG=440063 TBR=ygorshenin@chromium.org Original issue's description: > Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros. Also, fixed permissions checks for channel switcher UI in a multi-profiles sessions. > > BUG=433840 > TEST=existing unit_tests for OwnerSettingsService > > Committed: https://crrev.com/e0ed5a18bc9e3fa930f1af3b8f9c3cfdb91329f5 > Cr-Commit-Position: refs/heads/master@{#305012} TBR=nkostylev@chromium.org,ygorshenin@chromium.org NOTREECHECKS=true NOTRY=true BUG=433840 Committed: https://crrev.com/ed8e4785e42fdf65d79656fb922f2d1b16e9857b Cr-Commit-Position: refs/heads/master@{#307710}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -83 lines) Patch
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h View 1 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 8 chunks +12 lines, -25 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_basic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 1 5 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_mac.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
earthdok
Created Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros.
6 years ago (2014-12-10 15:54:14 UTC) #1
earthdok
6 years ago (2014-12-10 15:55:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790183002/1
6 years ago (2014-12-10 15:56:55 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/webui/help/help_handler.cc: While running git apply --index -3 -p1; error: patch ...
6 years ago (2014-12-10 15:58:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/790183002/250001
6 years ago (2014-12-10 16:12:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:250001)
6 years ago (2014-12-10 16:13:39 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ed8e4785e42fdf65d79656fb922f2d1b16e9857b Cr-Commit-Position: refs/heads/master@{#307710}
6 years ago (2014-12-10 16:14:34 UTC) #11
earthdok
On 2014/12/10 16:13:39, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:250001) The ...
6 years ago (2014-12-10 16:15:38 UTC) #12
earthdok
On 2014/12/10 16:15:38, earthdok wrote: > On 2014/12/10 16:13:39, I haz the power (commit-bot) wrote: ...
6 years ago (2014-12-10 16:20:14 UTC) #13
earthdok
6 years ago (2014-12-10 16:20:45 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:250001) has been created in
https://codereview.chromium.org/788243002/ by earthdok@chromium.org.

The reason for reverting is: Accidentally committed without CQ, broke build :(.

Powered by Google App Engine
This is Rietveld 408576698