Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

Issue 790183002: Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpda... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/settings/device_settings_service.h" 5 #include "chrome/browser/chromeos/settings/device_settings_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 owner_key_util_->Clear(); 262 owner_key_util_->Clear();
263 263
264 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 264 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
265 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 265 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
266 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 266 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
267 device_settings_service_.GetOwnershipStatus()); 267 device_settings_service_.GetOwnershipStatus());
268 268
269 const std::string& user_id = device_policy_.policy_data().username(); 269 const std::string& user_id = device_policy_.policy_data().username();
270 InitOwner(user_id, false); 270 InitOwner(user_id, false);
271 OwnerSettingsServiceChromeOS* service = 271 OwnerSettingsServiceChromeOS* service =
272 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 272 OwnerSettingsServiceChromeOSFactory::GetForProfile(profile_.get());
273 ASSERT_TRUE(service); 273 ASSERT_TRUE(service);
274 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 274 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
275 base::Unretained(this))); 275 base::Unretained(this)));
276 276
277 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 277 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
278 ReloadDeviceSettings(); 278 ReloadDeviceSettings();
279 279
280 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 280 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
281 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 281 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
282 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 282 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
(...skipping 24 matching lines...) Expand all
307 307
308 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 308 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
309 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 309 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
310 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 310 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
311 device_settings_service_.GetOwnershipStatus()); 311 device_settings_service_.GetOwnershipStatus());
312 312
313 const std::string& user_id = device_policy_.policy_data().username(); 313 const std::string& user_id = device_policy_.policy_data().username();
314 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 314 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
315 InitOwner(user_id, false); 315 InitOwner(user_id, false);
316 OwnerSettingsServiceChromeOS* service = 316 OwnerSettingsServiceChromeOS* service =
317 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 317 OwnerSettingsServiceChromeOSFactory::GetForProfile(profile_.get());
318 ASSERT_TRUE(service); 318 ASSERT_TRUE(service);
319 ReloadDeviceSettings(); 319 ReloadDeviceSettings();
320 320
321 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 321 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
322 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 322 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
323 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 323 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
324 std::vector<uint8> key; 324 std::vector<uint8> key;
325 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 325 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
326 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 326 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
327 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 327 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
(...skipping 15 matching lines...) Expand all
343 343
344 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 344 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
345 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 345 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
346 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 346 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
347 device_settings_service_.GetOwnershipStatus()); 347 device_settings_service_.GetOwnershipStatus());
348 348
349 const std::string& user_id = device_policy_.policy_data().username(); 349 const std::string& user_id = device_policy_.policy_data().username();
350 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 350 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
351 InitOwner(user_id, false); 351 InitOwner(user_id, false);
352 OwnerSettingsServiceChromeOS* service = 352 OwnerSettingsServiceChromeOS* service =
353 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 353 OwnerSettingsServiceChromeOSFactory::GetForProfile(profile_.get());
354 ASSERT_TRUE(service); 354 ASSERT_TRUE(service);
355 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 355 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
356 base::Unretained(this))); 356 base::Unretained(this)));
357 ReloadDeviceSettings(); 357 ReloadDeviceSettings();
358 358
359 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 359 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
360 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 360 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
361 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 361 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
362 std::vector<uint8> key; 362 std::vector<uint8> key;
363 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 363 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 400 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
401 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 401 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
402 std::vector<uint8> key; 402 std::vector<uint8> key;
403 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 403 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
404 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 404 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
405 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 405 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
406 device_settings_service_.GetOwnershipStatus()); 406 device_settings_service_.GetOwnershipStatus());
407 EXPECT_FALSE(is_owner_set_); 407 EXPECT_FALSE(is_owner_set_);
408 408
409 OwnerSettingsServiceChromeOS* service = 409 OwnerSettingsServiceChromeOS* service =
410 OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile_.get()); 410 OwnerSettingsServiceChromeOSFactory::GetForProfile(profile_.get());
411 ASSERT_TRUE(service); 411 ASSERT_TRUE(service);
412 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner, 412 service->IsOwnerAsync(base::Bind(&DeviceSettingsServiceTest::OnIsOwner,
413 base::Unretained(this))); 413 base::Unretained(this)));
414 // The callback should be called immediately. 414 // The callback should be called immediately.
415 base::MessageLoop::current()->RunUntilIdle(); 415 base::MessageLoop::current()->RunUntilIdle();
416 416
417 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey()); 417 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
418 ASSERT_TRUE(device_settings_service_.GetPublicKey().get()); 418 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
419 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 419 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
420 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 420 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
(...skipping 30 matching lines...) Expand all
451 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0); 451 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
452 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 452 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
453 device_settings_service_.PropertyChangeComplete(true); 453 device_settings_service_.PropertyChangeComplete(true);
454 FlushDeviceSettings(); 454 FlushDeviceSettings();
455 Mock::VerifyAndClearExpectations(&observer_); 455 Mock::VerifyAndClearExpectations(&observer_);
456 456
457 device_settings_service_.RemoveObserver(&observer_); 457 device_settings_service_.RemoveObserver(&observer_);
458 } 458 }
459 459
460 } // namespace chromeos 460 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698