chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc - Issue 790183002: Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpda...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

Issue 790183002: Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpda... (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

index 0d18b94f7e74acbf44728beb77fe0e629ef187f1..e6014c4040c1ee298f338549d729315af193af16 100644

--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

@@ -230,9 +230,8 @@ void CoreChromeOSOptionsHandler::SetPref(const std::string& pref_name,

return ::options::CoreOptionsHandler::SetPref(pref_name, value, metric);

Profile* profile = Profile::FromWebUI(web_ui());

OwnerSettingsServiceChromeOS* service =

- profile

- ? OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(profile)

- : nullptr;

+ profile ? OwnerSettingsServiceChromeOSFactory::GetForProfile(profile)

+ : nullptr;

if (service && service->HandlesSetting(pref_name))

service->Set(pref_name, *value);

else

« no previous file with comments | « chrome/browser/ui/webui/help/version_updater_win.cc ('k') | no next file » | no next file with comments »