Exposed the invalid state of form controls to the accessibility APIs.

Exposed the invalid state of form controls to the accessibility APIs.

BUG=384834
R=dmazzoni

Committed: https://crrev.com/4752162c54a5d5d36bbbb290e127a6b29c2a6e87
Cr-Commit-Position: refs/heads/master@{#311287}

[dmazzoni, 2014-12-19 17:30:34]

lgtm

Looks fantastic, only a few formatting nits!

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_cocoa.mm:413: return
base::SysUTF8ToNSString(ariaInvalidValue);
nit: this line should be indented 2 spaces less

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:2983: int
invalidState;
nit: invalid_state (c++ files in Chromium are like google3-style)

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3005: if
(GetString16Attribute(ui::AX_ATTR_ARIA_INVALID_VALUE,
nit: you need braces for both the "if" and "else" blocks because the else spans
multiple lines

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3007:
ia2_attributes_.push_back(L"invalid:" + ariaInvalidValue);
nit: indent 2 less

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3010:
ia2_attributes_.push_back(L"invalid:true");
nit: indent 2 less

https://codereview.chromium.org/790003003/diff/120001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_win.cc:3382: ia2_state_ |=
IA2_STATE_INVALID_ENTRY;
nit: indent 2 less

https://codereview.chromium.org/790003003/diff/120001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/790003003/diff/120001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:238:
dst->AddIntAttribute(ui::AX_ATTR_INVALID_STATE,
nit: indent 2 less, and use braces because this spans 2 lines

https://codereview.chromium.org/790003003/diff/120001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:241:
dst->AddStringAttribute(ui::AX_ATTR_ARIA_INVALID_VALUE,
same

[chromium-reviews, 2014-12-21 22:55:06]

Done.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2014-12-21 23:39:44]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2014-12-21 23:40:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790003003/140001

[commit-bot: I haz the power, 2014-12-22 01:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-22 01:16:58]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2015-01-12 21:26:53]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-01-12 21:28:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790003003/160001

[commit-bot: I haz the power, 2015-01-12 21:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-12 21:48:30]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[nektarios, 2015-01-12 22:38:14]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-01-12 22:38:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790003003/200001

[commit-bot: I haz the power, 2015-01-13 00:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 00:48:25]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[nektarios, 2015-01-13 16:02:02]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-01-13 16:02:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/790003003/220001

[commit-bot: I haz the power, 2015-01-13 17:50:54]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2015-01-13 17:51:57]

Patchset 12 (id:??) landed as
https://crrev.com/4752162c54a5d5d36bbbb290e127a6b29c2a6e87
Cr-Commit-Position: refs/heads/master@{#311287}