Exposed the invalid state of form controls to the accessibility APIs.

content/renderer/accessibility/blink_ax_tree_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/accessibility/blink_ax_tree_source.h"
 
 #include <set>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 216 matching lines @@
   }
 
   if (dst->role == ui::AX_ROLE_COLOR_WELL) {
     int r, g, b;
     src.colorValue(r, g, b);
     dst->AddIntAttribute(ui::AX_ATTR_COLOR_VALUE_RED, r);
     dst->AddIntAttribute(ui::AX_ATTR_COLOR_VALUE_GREEN, g);
     dst->AddIntAttribute(ui::AX_ATTR_COLOR_VALUE_BLUE, b);
   }
 
+  if (src.invalidState())
+      dst->AddIntAttribute(ui::AX_ATTR_INVALID_STATE,

[dmazzoni, 2014/12/19 17:30:34]

nit: indent 2 less, and use braces because this spans 2 lines

+                           AXInvalidStateFromBlink(src.invalidState()));
+  if (src.invalidState() == blink::WebAXInvalidStateOther)
+      dst->AddStringAttribute(ui::AX_ATTR_ARIA_INVALID_VALUE,

[dmazzoni, 2014/12/19 17:30:34]

same

+                              UTF16ToUTF8(src.ariaInvalidValue()));
+
   if (dst->role == ui::AX_ROLE_INLINE_TEXT_BOX) {
     dst->AddIntAttribute(ui::AX_ATTR_TEXT_DIRECTION,
                          AXTextDirectionFromBlink(src.textDirection()));
 
     WebVector<int> src_character_offsets;
     src.characterOffsets(src_character_offsets);
     std::vector<int32> character_offsets;
     character_offsets.reserve(src_character_offsets.size());
     for (size_t i = 0; i < src_character_offsets.size(); ++i)
       character_offsets.push_back(src_character_offsets[i]);
@@ skipping 11 matching lines @@
       word_ends.push_back(src_word_ends[i]);
     }
     dst->AddIntListAttribute(ui::AX_ATTR_WORD_STARTS, word_starts);
     dst->AddIntListAttribute(ui::AX_ATTR_WORD_ENDS, word_ends);
   }
 
   if (src.accessKey().length()) {
     dst->AddStringAttribute(ui::AX_ATTR_ACCESS_KEY,
     UTF16ToUTF8(src.accessKey()));
   }
+
   if (src.actionVerb().length())
     dst->AddStringAttribute(ui::AX_ATTR_ACTION, UTF16ToUTF8(src.actionVerb()));
   if (src.ariaAutoComplete().length())
     dst->AddStringAttribute(ui::AX_ATTR_AUTO_COMPLETE,
                             UTF16ToUTF8(src.ariaAutoComplete()));
   if (src.isAriaReadOnly())
     dst->AddBoolAttribute(ui::AX_ATTR_ARIA_READONLY, true);
   if (src.isButtonStateMixed())
     dst->AddBoolAttribute(ui::AX_ATTR_BUTTON_MIXED, true);
   if (src.canSetValueAttribute())
@@ skipping 289 matching lines @@
     AddIntListAttributeFromWebObjects(ui::AX_ATTR_OWNS_IDS, owns, dst);
 }
 
 blink::WebDocument BlinkAXTreeSource::GetMainDocument() const {
   if (render_frame_ && render_frame_->GetWebFrame())
     return render_frame_->GetWebFrame()->document();
   return WebDocument();
 }
 
 }  // namespace content