content/renderer/accessibility/blink_ax_tree_source.cc - Issue 790003003: Exposed the invalid state of form controls to the accessibility APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 790003003: Exposed the invalid state of form controls to the accessibility APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tried fixing Android unit tests. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/accessibility/blink_ax_enum_conversion.cc ('k') | content/test/data/accessibility/aria/aria-invalid.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 0ebbc980e142737ae6aacb4f4c57c5671787e27c..4197c4e652f026fb295e2250fb9c445a6a737692 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -236,6 +236,15 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

dst->AddIntAttribute(ui::AX_ATTR_COLOR_VALUE_BLUE, b);

}

+ if (src.invalidState()) {

+ dst->AddIntAttribute(ui::AX_ATTR_INVALID_STATE,

+ AXInvalidStateFromBlink(src.invalidState()));

+ }

+ if (src.invalidState() == blink::WebAXInvalidStateOther) {

+ dst->AddStringAttribute(ui::AX_ATTR_ARIA_INVALID_VALUE,

+ UTF16ToUTF8(src.ariaInvalidValue()));

+ }

if (dst->role == ui::AX_ROLE_INLINE_TEXT_BOX) {

dst->AddIntAttribute(ui::AX_ATTR_TEXT_DIRECTION,

AXTextDirectionFromBlink(src.textDirection()));

@@ -267,6 +276,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

dst->AddStringAttribute(ui::AX_ATTR_ACCESS_KEY,

UTF16ToUTF8(src.accessKey()));

}

if (src.actionVerb().length())

dst->AddStringAttribute(ui::AX_ATTR_ACTION, UTF16ToUTF8(src.actionVerb()));

if (src.ariaAutoComplete().length())