Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index cfad1196e1904c640ff28fc875d8889788d4aee4..9ed36fff22dff1f095e217a00eb7fad21ed26636 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3414,6 +3414,18 @@ void RenderFrameImpl::didChangeManifest(blink::WebLocalFrame* frame)
FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeManifest());
}
+bool RenderFrameImpl::enterFullscreen()
dcheng 2014/12/10 06:58:00 What's the point of having a bool return value if
mlamouri (slow - plz ping) 2014/12/10 15:47:02 It's only in order to do the transition in Blink.
dcheng 2014/12/10 20:45:01 Let's make sure to clean this up afterwards.
+{
+ Send(new FrameHostMsg_ToggleFullscreen(routing_id_, true));
+ return true;
+}
+
+bool RenderFrameImpl::exitFullscreen()
+{
+ Send(new FrameHostMsg_ToggleFullscreen(routing_id_, false));
+ return true;
+}
+
void RenderFrameImpl::DidPlay(blink::WebMediaPlayer* player) {
Send(new FrameHostMsg_MediaPlayingNotification(
routing_id_, reinterpret_cast<int64>(player), player->hasVideo(),

Powered by Google App Engine
This is Rietveld 408576698