Fullscreen: make fullscreen requests come from RenderFrame

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 3396 matching lines @@
   }
 }
 
 void RenderFrameImpl::didChangeManifest(blink::WebLocalFrame* frame)
 {
   DCHECK(!frame_ || frame_ == frame);
 
   FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeManifest());
 }
 
+bool RenderFrameImpl::enterFullscreen()

[dcheng, 2014/12/10 06:58:00]

What's the point of having a bool return value if we always return true?

[mlamouri (slow - plz ping), 2014/12/10 15:47:02]

It's only in order to do the transition in Blink. WebFrameClient default
implementation returns false so I can fallback to WebWidgetClient.

[dcheng, 2014/12/10 20:45:01]

Let's make sure to clean this up afterwards.

+{
+  Send(new FrameHostMsg_ToggleFullscreen(routing_id_, true));
+  return true;
+}
+
+bool RenderFrameImpl::exitFullscreen()
+{
+  Send(new FrameHostMsg_ToggleFullscreen(routing_id_, false));
+  return true;
+}
+
 void RenderFrameImpl::DidPlay(blink::WebMediaPlayer* player) {
   Send(new FrameHostMsg_MediaPlayingNotification(
       routing_id_, reinterpret_cast<int64>(player), player->hasVideo(),
       player->hasAudio(), player->isRemote()));
 }
 
 void RenderFrameImpl::DidPause(blink::WebMediaPlayer* player) {
   Send(new FrameHostMsg_MediaPausedNotification(
       routing_id_, reinterpret_cast<int64>(player)));
 }
@@ skipping 839 matching lines @@
 
 #if defined(ENABLE_BROWSER_CDMS)
 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
   if (!cdm_manager_)
     cdm_manager_ = new RendererCdmManager(this);
   return cdm_manager_;
 }
 #endif  // defined(ENABLE_BROWSER_CDMS)
 
 }  // namespace content