Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 789533002: Fullscreen: make fullscreen requests come from RenderFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 17bed7fbf401461207400c972c1e4f6892923b55..9b1eaf33566761fe96e19a2d19d5199d09953e56 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -372,7 +372,11 @@ class CONTENT_EXPORT WebContentsDelegate {
virtual bool EmbedsFullscreenWidget() const;
// Called when the renderer puts a tab into or out of fullscreen mode.
+ // |origin| will always be empty when |enter_fullscreen| is false.
Charlie Reis 2014/12/10 00:51:21 These comments help, but please first say what |or
mlamouri (slow - plz ping) 2014/12/10 15:47:02 Done.
+ // |origin| can be empty when |enter_fullscreen| in which case the
Charlie Reis 2014/12/10 00:51:21 when |enter_fullscreen| is true, in which case...
mlamouri (slow - plz ping) 2014/12/10 15:47:02 No longer exists.
+ // implementation is expected to use |web_contents|' origin instead.
virtual void ToggleFullscreenModeForTab(WebContents* web_contents,
+ const GURL& origin,
bool enter_fullscreen) {}
virtual bool IsFullscreenForTabOrPending(
const WebContents* web_contents) const;

Powered by Google App Engine
This is Rietveld 408576698