Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 789233002: Revert of Revert of Enable telemetry unittests on Mac 10.9 (Closed)

Created:
6 years ago by sullivan
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/792683002/) Reason for revert: The failing test was disabled in https://codereview.chromium.org/789043003 Original issue's description: > Revert of Enable telemetry unittests on Mac 10.9 (patchset #1 id:1 of https://codereview.chromium.org/779943004/) > > Reason for revert: > Tests fail with a different error. > > Original issue's description: > > Enable telemetry unittests on Mac 10.9 > > > > The tests were fixed in https://codereview.chromium.org/789853003 > > > > BUG=423688 > > > > Committed: https://crrev.com/e0fe19f3e05e83e820be8a8e2850853bc0434b21 > > Cr-Commit-Position: refs/heads/master@{#307522} > > TBR=tonyg@chromium.org,phajdan.jr@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=423688 > > Committed: https://crrev.com/dbf34f1e5d36e433c9d30df974da8c5f6fa665e5 > Cr-Commit-Position: refs/heads/master@{#307553} TBR=tonyg@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=423688 Committed: https://crrev.com/1e2366706b52428a3a6355864b6e9a845216ae3d Cr-Commit-Position: refs/heads/master@{#307696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sullivan
Created Revert of Revert of Enable telemetry unittests on Mac 10.9
6 years ago (2014-12-10 14:34:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789233002/1
6 years ago (2014-12-10 14:35:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 14:35:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1e2366706b52428a3a6355864b6e9a845216ae3d Cr-Commit-Position: refs/heads/master@{#307696}
6 years ago (2014-12-10 14:36:26 UTC) #4
dvh
6 years ago (2014-12-10 18:10:56 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/788263002/ by dvh@chromium.org.

The reason for reverting is: Telemetry tests still fails..

Powered by Google App Engine
This is Rietveld 408576698