Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 789853003: [Telemetry] Don't fail powermetrics unit tests when run on a VM. (Closed)

Created:
6 years ago by jeremy
Modified:
6 years ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Don't fail powermetrics unit tests when run on a VM. When running on a VM, the output of power metrics changes causing the parsing code to fail, notably the 'component_utilization' section doesn't appear. Return empty output rather than throwing an exception when parsing. BUG=423688 Committed: https://crrev.com/a8219a1ccb145b58fa0cd449365bcec3cdfc52f4 Cr-Commit-Position: refs/heads/master@{#307478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2911 lines, -9 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py View 4 chunks +17 lines, -9 lines 0 comments Download
A tools/telemetry/unittest_data/powermetrics_vmware.output View 1 chunk +2889 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jeremy
6 years ago (2014-12-09 14:24:10 UTC) #2
Sami
Heh, good find. lgtm.
6 years ago (2014-12-09 14:27:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789853003/1
6 years ago (2014-12-09 14:39:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 15:38:49 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 15:40:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8219a1ccb145b58fa0cd449365bcec3cdfc52f4
Cr-Commit-Position: refs/heads/master@{#307478}

Powered by Google App Engine
This is Rietveld 408576698