Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 789043003: [Telemetry] Disable testPowerMonitoringSync test on Mac & cleanup test macros (Closed)

Created:
6 years ago by jeremy
Modified:
6 years ago
Reviewers:
Sami, marja
CC:
chromium-reviews, telemetry+watch_chromium.org, sullivan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Disable testPowerMonitoringSync test on Mac & cleanup test macros testPowerMonitoringSync is an end-end test for power measurement and requires hardware that supports power usage measurement. The Telemetry unit tests are currently run on a VM on the bots and don't support power measurement. Disable this test in the interim. In addition this CL changes a bunch of uses of benchmark.Disabled/Enabled -> telemetry.unit_test_util.test.Disabled/Enabled in unit tests. BUG=440666 Committed: https://crrev.com/ae2ef3a160cd901e89ac3ef69d3edb6efb33b53a Cr-Commit-Position: refs/heads/master@{#307687}

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove blankline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tools/telemetry/telemetry/core/platform/platform_backend_unittest.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jeremy
6 years ago (2014-12-10 06:15:29 UTC) #2
marja
rubberstamp lgtm, as you know better than me why the benchmark.Disabled/Enabled -> telemetry.unit_test_util.test.Disabled/Enabled is the ...
6 years ago (2014-12-10 10:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/789043003/20001
6 years ago (2014-12-10 11:20:34 UTC) #6
Sami
lgtm x2
6 years ago (2014-12-10 12:04:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-10 13:15:49 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-10 13:16:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae2ef3a160cd901e89ac3ef69d3edb6efb33b53a
Cr-Commit-Position: refs/heads/master@{#307687}

Powered by Google App Engine
This is Rietveld 408576698