Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 788533002: make SkColorShader private, use public factory (Closed)

Created:
6 years ago by reed2
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

make SkColorShader private, use public factory BUG=skia: Need https://codereview.chromium.org/785823002/ to land first Committed: https://skia.googlesource.com/skia/+/b9bb38cd187bfd43abfa8577da0ab4e34d181073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -78 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -1 line 0 comments Download
D include/core/SkColorShader.h View 1 chunk +0 lines, -78 lines 0 comments Download
A + src/core/SkColorShader.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
reed2
6 years ago (2014-12-07 20:54:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788533002/1
6 years ago (2014-12-07 20:54:55 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-07 20:54:55 UTC) #5
f(malita)
lgtm
6 years ago (2014-12-08 00:51:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788533002/1
6 years ago (2014-12-08 14:06:26 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-08 14:06:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b9bb38cd187bfd43abfa8577da0ab4e34d181073

Powered by Google App Engine
This is Rietveld 408576698