Issue 787043006: Detect discarded SkPictureShader pixel refs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787043006: Detect discarded SkPictureShader pixel refs. (Closed)

Created:
6 years ago by f(malita)

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Detect discarded SkPictureShader pixel refs. This doesn't address the more general problem, but reduces the race window significantly. BUG=440282 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/387a01a6357b4ba6ff87ac57626de1cb6a3b31bf

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	src/core/SkPictureShader.cpp	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

f(malita)

WDYT about this as a stop-gap for http://crbug.com/440282 (while I'm working on the real fix)?

6 years ago (2014-12-10 18:17:33 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787043006/20001

6 years ago (2014-12-10 18:54:27 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-10 20:18:02 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/387a01a6357b4ba6ff87ac57626de1cb6a3b31bf