chrome/browser/sync/js/js_sync_manager_observer.cc - Issue 7861013: Fix the false-positive detection of commit errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/js/js_sync_manager_observer.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/js/js_sync_manager_observer.cc

diff --git a/chrome/browser/sync/js/js_sync_manager_observer.cc b/chrome/browser/sync/js/js_sync_manager_observer.cc

index 7714f27422a7bc145920411c0620b84d0015e571..d3819acb8ffad4b943bfeef5718c5f261abe436b 100644

--- a/chrome/browser/sync/js/js_sync_manager_observer.cc

+++ b/chrome/browser/sync/js/js_sync_manager_observer.cc

@@ -19,7 +19,7 @@

namespace browser_sync {

-using browser_sync::SyncProtocolError;

+using browser_sync::SyncOperationResult;

JsSyncManagerObserver::JsSyncManagerObserver() {}

@@ -92,7 +92,7 @@ void JsSyncManagerObserver::OnEncryptionComplete(

}

void JsSyncManagerObserver::OnActionableError(

- const SyncProtocolError& sync_error) {

+ const SyncOperationResult& sync_error) {

if (!event_handler_.IsInitialized()) {

return;

}