chrome/browser/sync/js/js_sync_manager_observer.h - Issue 7861013: Fix the false-positive detection of commit errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/js/js_sync_manager_observer.h

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/js/js_sync_manager_observer.h

diff --git a/chrome/browser/sync/js/js_sync_manager_observer.h b/chrome/browser/sync/js/js_sync_manager_observer.h

index 0fa1db317e302e5b8b08686c34ba0974a10659c2..be7977ee5845234a27b4eaa23afb6cc7f9cf393b 100644

--- a/chrome/browser/sync/js/js_sync_manager_observer.h

+++ b/chrome/browser/sync/js/js_sync_manager_observer.h

@@ -48,7 +48,7 @@ class JsSyncManagerObserver : public sync_api::SyncManager::Observer {

virtual void OnClearServerDataSucceeded() OVERRIDE;

virtual void OnClearServerDataFailed() OVERRIDE;

virtual void OnActionableError(

- const browser_sync::SyncProtocolError& sync_protocol_error) OVERRIDE;

+ const browser_sync::SyncOperationResult& sync_protocol_error) OVERRIDE;

private:

void HandleJsEvent(const tracked_objects::Location& from_here,