chrome/browser/sync/js/js_sync_manager_observer_unittest.cc - Issue 7861013: Fix the false-positive detection of commit errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

diff --git a/chrome/browser/sync/js/js_sync_manager_observer_unittest.cc b/chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

index aa1f0f1f282a13129705ac0cc393c73ea2bcfd67..b69919f60b714fdea3dc6ee2927cc456ea4d970a 100644

--- a/chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

+++ b/chrome/browser/sync/js/js_sync_manager_observer_unittest.cc

@@ -96,7 +96,7 @@ TEST_F(JsSyncManagerObserverTest, OnSyncCycleCompleted) {

}

TEST_F(JsSyncManagerObserverTest, OnActionableError) {

- browser_sync::SyncProtocolError sync_error;

+ browser_sync::SyncOperationResult sync_error;

sync_error.action = browser_sync::CLEAR_USER_DATA_AND_RESYNC;

sync_error.error_type = browser_sync::TRANSIENT_ERROR;

DictionaryValue expected_details;