Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 784283006: chrome.identity API: Restrict gaia ID access (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome.identity API: Restrict gaia ID access This restricts the availability of obfuscated GAIA ID info (from chrome.identity.getProfileUserInfo) to apps which specify the identity.email manifest permission. BUG=415641 Committed: https://crrev.com/d6084a9790eafe0ca4e980c0a3d10d05566bb383 Cr-Commit-Position: refs/heads/master@{#311570}

Patch Set 1 #

Patch Set 2 : reuse identity.email, kill identity.gaiaId #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/identity.idl View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Ken Rockot(use gerrit already)
asargent: Could you please take a look for general extensions ownership? vabr: Could you please ...
5 years, 11 months ago (2015-01-11 02:33:52 UTC) #2
vabr (Chromium)
Thanks for looping me in for the string, Ken. Currently we have concerns that the ...
5 years, 11 months ago (2015-01-12 08:55:34 UTC) #3
vabr (Chromium)
The promised update is in http://crbug.com/415641#c23. That is: * Please do put the access to ...
5 years, 11 months ago (2015-01-12 13:29:16 UTC) #4
Ken Rockot(use gerrit already)
Ok, CL and description updated according to the conclusions outlined by vabr@. Ready for your ...
5 years, 11 months ago (2015-01-14 20:33:45 UTC) #5
asargent_no_longer_on_chrome
lgtm
5 years, 11 months ago (2015-01-14 20:39:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/784283006/20001
5 years, 11 months ago (2015-01-14 21:08:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 23:26:47 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:27:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6084a9790eafe0ca4e980c0a3d10d05566bb383
Cr-Commit-Position: refs/heads/master@{#311570}

Powered by Google App Engine
This is Rietveld 408576698