chrome/browser/extensions/api/identity/identity_api.cc - Issue 784283006: chrome.identity API: Restrict gaia ID access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_api.cc

Issue 784283006: chrome.identity API: Restrict gaia ID access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reuse identity.email, kill identity.gaiaId Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/identity_api.cc

diff --git a/chrome/browser/extensions/api/identity/identity_api.cc b/chrome/browser/extensions/api/identity/identity_api.cc

index 4b9562ba1cc37038b5596fb77e923c03b3ac1756..3cd86688e91bf6d8259b99653a44f45e4480f37c 100644

--- a/chrome/browser/extensions/api/identity/identity_api.cc

+++ b/chrome/browser/extensions/api/identity/identity_api.cc

@@ -852,8 +852,8 @@ ExtensionFunction::ResponseAction IdentityGetProfileUserInfoFunction::Run() {

if (extension()->permissions_data()->HasAPIPermission(

APIPermission::kIdentityEmail)) {

profile_user_info.email = account.email;

+ profile_user_info.id = account.gaia;

}

- profile_user_info.id = account.gaia;

return RespondNow(OneArgument(profile_user_info.ToValue().release()));

}

« no previous file with comments | « no previous file | chrome/browser/extensions/api/identity/identity_apitest.cc » ('j') | no next file with comments »