chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 784283006: chrome.identity API: Restrict gaia ID access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 784283006: chrome.identity API: Restrict gaia ID access (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reuse identity.email, kill identity.gaiaId Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index 9eeade1f06698de48f4f2df86d6be525204517ed..5ff783d700c988e691d65f4091203d9a5a596319 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -653,7 +653,7 @@ IN_PROC_BROWSER_TEST_F(IdentityGetProfileUserInfoFunctionTest,

SignIn("president@example.com", "12345");

scoped_ptr<api::identity::ProfileUserInfo> info = RunGetProfileUserInfo();

EXPECT_TRUE(info->email.empty());

- EXPECT_EQ("12345", info->id);

+ EXPECT_TRUE(info->id.empty());

}

class GetAuthTokenFunctionTest : public IdentityTestWithSignin {