Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 7841036: Fix several bugs in compaction: (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix several bugs in compaction: - when evicting evacuation candidates from free list create filler covering [top, limit) to ensure that page will remain iterable if it was iterable. this is important for Code space pages. - we should not split typed slots between two slots buffers because we traverse them in opposite order. - when recording reloc slot ensure that reloc host is not null before checking host's page flags. R=erik.corry@gmail.com BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -56 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mark-compact.h View 4 chunks +11 lines, -16 lines 0 comments Download
M src/mark-compact.cc View 5 chunks +20 lines, -28 lines 0 comments Download
M src/objects-visiting-inl.h View 3 chunks +2 lines, -8 lines 0 comments Download
M src/spaces.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-07 14:04:49 UTC) #1
Erik Corry
9 years, 3 months ago (2011-09-07 14:38:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698