Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 783923005: Oilpan: move InspectorOverlay to the heap. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: move InspectorOverlay to the heap. Thereby avoiding its Persistent references. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186935

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M Source/core/inspector/InspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorController.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.h View 2 chunks +10 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look. This appears to simply have been overlooked; I don't see any ...
6 years ago (2014-12-10 22:10:47 UTC) #2
haraken
LGTM https://codereview.chromium.org/783923005/diff/1/Source/core/inspector/InspectorOverlay.cpp File Source/core/inspector/InspectorOverlay.cpp (right): https://codereview.chromium.org/783923005/diff/1/Source/core/inspector/InspectorOverlay.cpp#newcode354 Source/core/inspector/InspectorOverlay.cpp:354: ASSERT(!m_overlayPage); I think this should be in #if ...
6 years ago (2014-12-10 23:44:22 UTC) #4
sof
Thanks for the review. https://codereview.chromium.org/783923005/diff/1/Source/core/inspector/InspectorOverlay.cpp File Source/core/inspector/InspectorOverlay.cpp (right): https://codereview.chromium.org/783923005/diff/1/Source/core/inspector/InspectorOverlay.cpp#newcode354 Source/core/inspector/InspectorOverlay.cpp:354: ASSERT(!m_overlayPage); On 2014/12/10 23:44:22, haraken ...
6 years ago (2014-12-11 08:11:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783923005/1
6 years ago (2014-12-11 08:12:02 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-11 10:31:49 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186935

Powered by Google App Engine
This is Rietveld 408576698