Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 783923005: Oilpan: move InspectorOverlay to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InspectorOverlay.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 , m_drawViewSizeWithGrid(false) 344 , m_drawViewSizeWithGrid(false)
345 , m_omitTooltip(false) 345 , m_omitTooltip(false)
346 , m_timer(this, &InspectorOverlay::onTimer) 346 , m_timer(this, &InspectorOverlay::onTimer)
347 , m_activeProfilerCount(0) 347 , m_activeProfilerCount(0)
348 , m_updating(false) 348 , m_updating(false)
349 { 349 {
350 } 350 }
351 351
352 InspectorOverlay::~InspectorOverlay() 352 InspectorOverlay::~InspectorOverlay()
353 { 353 {
354 ASSERT(!m_overlayPage); 354 ASSERT(!m_overlayPage);
haraken 2014/12/10 23:44:22 I think this should be in #if !ENABLE(OILPAN).
sof 2014/12/11 08:11:10 It checks that freePage() has been called, ensurin
355 } 355 }
356 356
357 void InspectorOverlay::trace(Visitor* visitor)
358 {
359 visitor->trace(m_page);
360 visitor->trace(m_highlightNode);
361 visitor->trace(m_eventTargetNode);
362 visitor->trace(m_overlayPage);
363 visitor->trace(m_overlayHost);
364 }
365
357 void InspectorOverlay::paint(GraphicsContext& context) 366 void InspectorOverlay::paint(GraphicsContext& context)
358 { 367 {
359 if (isEmpty()) 368 if (isEmpty())
360 return; 369 return;
361 GraphicsContextStateSaver stateSaver(context); 370 GraphicsContextStateSaver stateSaver(context);
362 FrameView* view = toLocalFrame(overlayPage()->mainFrame())->view(); 371 FrameView* view = toLocalFrame(overlayPage()->mainFrame())->view();
363 ASSERT(!view->needsLayout()); 372 ASSERT(!view->needsLayout());
364 view->paint(&context, IntRect(0, 0, view->width(), view->height())); 373 view->paint(&context, IntRect(0, 0, view->width(), view->height()));
365 } 374 }
366 375
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
878 hideHighlight(); 887 hideHighlight();
879 } 888 }
880 889
881 void InspectorOverlay::startedRecordingProfile() 890 void InspectorOverlay::startedRecordingProfile()
882 { 891 {
883 if (!m_activeProfilerCount++) 892 if (!m_activeProfilerCount++)
884 freePage(); 893 freePage();
885 } 894 }
886 895
887 } // namespace blink 896 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorOverlay.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698