Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: Source/core/inspector/InspectorOverlay.h

Issue 783923005: Oilpan: move InspectorOverlay to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorOverlay.h
diff --git a/Source/core/inspector/InspectorOverlay.h b/Source/core/inspector/InspectorOverlay.h
index da8e5b9c9d27183f981062a0ad4c307b55423194..9f3ae57b4b337546e20566999b46ae5654a5a178 100644
--- a/Source/core/inspector/InspectorOverlay.h
+++ b/Source/core/inspector/InspectorOverlay.h
@@ -72,15 +72,16 @@ public:
bool showExtensionLines;
};
-class InspectorOverlay {
- WTF_MAKE_FAST_ALLOCATED;
+class InspectorOverlay final : public NoBaseWillBeGarbageCollectedFinalized<InspectorOverlay> {
+ WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
- static PassOwnPtr<InspectorOverlay> create(Page* page, InspectorClient* client)
+ static PassOwnPtrWillBeRawPtr<InspectorOverlay> create(Page* page, InspectorClient* client)
{
- return adoptPtr(new InspectorOverlay(page, client));
+ return adoptPtrWillBeNoop(new InspectorOverlay(page, client));
}
~InspectorOverlay();
+ void trace(Visitor*);
void update();
void hide();
@@ -128,17 +129,17 @@ private:
void evaluateInOverlay(const String& method, PassRefPtr<JSONValue> argument);
void onTimer(Timer<InspectorOverlay>*);
- Page* m_page;
+ RawPtrWillBeMember<Page> m_page;
InspectorClient* m_client;
String m_pausedInDebuggerMessage;
bool m_inspectModeEnabled;
- RefPtrWillBePersistent<Node> m_highlightNode;
- RefPtrWillBePersistent<Node> m_eventTargetNode;
+ RefPtrWillBeMember<Node> m_highlightNode;
+ RefPtrWillBeMember<Node> m_eventTargetNode;
HighlightConfig m_nodeHighlightConfig;
OwnPtr<FloatQuad> m_highlightQuad;
- OwnPtrWillBePersistent<Page> m_overlayPage;
+ OwnPtrWillBeMember<Page> m_overlayPage;
OwnPtr<EmptyChromeClient> m_overlayChromeClient;
- RefPtrWillBePersistent<InspectorOverlayHost> m_overlayHost;
+ RefPtrWillBeMember<InspectorOverlayHost> m_overlayHost;
HighlightConfig m_quadHighlightConfig;
bool m_drawViewSize;
bool m_drawViewSizeWithGrid;

Powered by Google App Engine
This is Rietveld 408576698