Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 783233002: Get rid of PaintPhaseTextClip. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
esprehn, rafaelw, eseidel
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Get rid of PaintPhaseTextClip. This was just used for background-clip:text, which we no longer support. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d8744d65be2fdd70782d833ce4f5908f6685458f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M sky/engine/core/rendering/GraphicsContextAnnotator.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/InlineTextBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/PaintPhase.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLineBoxList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years ago (2014-12-08 19:17:40 UTC) #2
rafaelw
lgtm
6 years ago (2014-12-08 19:21:11 UTC) #3
ojan
6 years ago (2014-12-08 19:23:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d8744d65be2fdd70782d833ce4f5908f6685458f.

Powered by Google App Engine
This is Rietveld 408576698