sky/engine/core/rendering/RenderBlock.cpp - Issue 783233002: Get rid of PaintPhaseTextClip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlock.cpp

Issue 783233002: Get rid of PaintPhaseTextClip. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlock.cpp

diff --git a/sky/engine/core/rendering/RenderBlock.cpp b/sky/engine/core/rendering/RenderBlock.cpp

index eb53c309c375aabc04882f2cc919f227711676f6..e4f0aef242d707e408c6480be3b46e30cf40372e 100644

--- a/sky/engine/core/rendering/RenderBlock.cpp

+++ b/sky/engine/core/rendering/RenderBlock.cpp

@@ -655,7 +655,7 @@ void RenderBlock::paintAsInlineBlock(RenderObject* renderer, PaintInfo& paintInf

// stacking context. (See Appendix E.2, section 7.2.1.4 on

// inline block/table/replaced elements in the CSS2.1 specification.)

// This is also used by other elements (e.g. flex items).

- bool preservePhase = paintInfo.phase == PaintPhaseSelection || paintInfo.phase == PaintPhaseTextClip;

+ bool preservePhase = paintInfo.phase == PaintPhaseSelection;

PaintInfo info(paintInfo);

info.phase = preservePhase ? paintInfo.phase : PaintPhaseBlockBackground;

renderer->paint(info, childPoint);