Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: sky/engine/core/rendering/RenderLineBoxList.cpp

Issue 783233002: Get rid of PaintPhaseTextClip. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 LayoutUnit logicalTop = std::min<LayoutUnit>(box->logicalTopVisualOverflow(r oot.lineTop()), root.selectionTop()); 182 LayoutUnit logicalTop = std::min<LayoutUnit>(box->logicalTopVisualOverflow(r oot.lineTop()), root.selectionTop());
183 LayoutUnit logicalBottom = box->logicalBottomVisualOverflow(root.lineBottom( )); 183 LayoutUnit logicalBottom = box->logicalBottomVisualOverflow(root.lineBottom( ));
184 184
185 return rangeIntersectsRect(renderer, logicalTop, logicalBottom, paintInfo.re ct, offset); 185 return rangeIntersectsRect(renderer, logicalTop, logicalBottom, paintInfo.re ct, offset);
186 } 186 }
187 187
188 void RenderLineBoxList::paint(RenderBoxModelObject* renderer, PaintInfo& paintIn fo, const LayoutPoint& paintOffset) const 188 void RenderLineBoxList::paint(RenderBoxModelObject* renderer, PaintInfo& paintIn fo, const LayoutPoint& paintOffset) const
189 { 189 {
190 // Only paint during the foreground/selection phases. 190 // Only paint during the foreground/selection phases.
191 if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhase Selection && paintInfo.phase != PaintPhaseOutline 191 if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhase Selection && paintInfo.phase != PaintPhaseOutline
192 && paintInfo.phase != PaintPhaseSelfOutline && paintInfo.phase != PaintP haseChildOutlines && paintInfo.phase != PaintPhaseTextClip 192 && paintInfo.phase != PaintPhaseSelfOutline && paintInfo.phase != PaintP haseChildOutlines
193 && paintInfo.phase != PaintPhaseMask) 193 && paintInfo.phase != PaintPhaseMask)
194 return; 194 return;
195 195
196 ASSERT(renderer->isRenderBlock() || (renderer->isRenderInline() && renderer- >hasLayer())); // The only way an inline could paint like this is if it has a la yer. 196 ASSERT(renderer->isRenderBlock() || (renderer->isRenderInline() && renderer- >hasLayer())); // The only way an inline could paint like this is if it has a la yer.
197 197
198 // If we have no lines then we have no work to do. 198 // If we have no lines then we have no work to do.
199 if (!firstLineBox()) 199 if (!firstLineBox())
200 return; 200 return;
201 201
202 if (!anyLineIntersectsRect(renderer, paintInfo.rect, paintOffset)) 202 if (!anyLineIntersectsRect(renderer, paintInfo.rect, paintOffset))
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 ASSERT(child->prevLineBox() == prev); 358 ASSERT(child->prevLineBox() == prev);
359 prev = child; 359 prev = child;
360 } 360 }
361 ASSERT(prev == m_lastLineBox); 361 ASSERT(prev == m_lastLineBox);
362 #endif 362 #endif
363 } 363 }
364 364
365 #endif 365 #endif
366 366
367 } 367 }
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698