Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 782853002: Revert of Implement unset value handling (Closed)

Created:
6 years ago by Ilya Sherman
Modified:
6 years ago
Reviewers:
Timothy Loh, rwlbuis
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Implement unset value handling (patchset #4 id:80001 of https://codereview.chromium.org/775153002/) Reason for revert: This broke the Linux Oilpan Builder. Logs: http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/builds/13454/steps/compile/logs/stdio#error1 BUG=439604 Original issue's description: > Implement unset value handling > > This patch accepts unset as a valid CSS value and creates > a CSSUnsetValue object for it. Then when resolving it the > rules stated in below link are implemented: > > http://dev.w3.org/csswg/css-cascade/#valuedef-unset > > Add a test for the new behavior. > > BUG=431689 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186604 TBR=timloh@chromium.org,rob.buis@samsung.com NOTREECHECKS=true NOTRY=true BUG=431689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -119 lines) Patch
D LayoutTests/fast/css/unset-keyword.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/css/unset-keyword-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/css/CSSUnsetValue.h View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/core/css/CSSUnsetValue.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 6 chunks +0 lines, -14 lines 0 comments Download
M Source/core/css/CSSValuePool.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
Created Revert of Implement unset value handling
6 years ago (2014-12-05 22:33:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/782853002/1
6 years ago (2014-12-05 22:34:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=186627
6 years ago (2014-12-05 22:34:50 UTC) #3
Timothy Loh
On 2014/12/05 22:34:50, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years ago (2014-12-06 00:42:44 UTC) #4
Ilya Sherman
On 2014/12/06 00:42:44, Timothy Loh wrote: > On 2014/12/05 22:34:50, I haz the power (commit-bot) ...
6 years ago (2014-12-06 00:45:07 UTC) #5
Ilya Sherman
6 years ago (2014-12-06 01:16:27 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/773483003/ by isherman@chromium.org.

The reason for reverting is: A build fix has landed, so the revert is no longer
necessary..

Powered by Google App Engine
This is Rietveld 408576698