Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 773483003: Revert of Revert of Implement unset value handling (Closed)

Created:
6 years ago by Ilya Sherman
Modified:
6 years ago
Reviewers:
Timothy Loh, rwlbuis
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Implement unset value handling (patchset #1 id:1 of https://codereview.chromium.org/782853002/) Reason for revert: A build fix has landed, so the revert is no longer necessary. Original issue's description: > Revert of Implement unset value handling (patchset #4 id:80001 of https://codereview.chromium.org/775153002/) > > Reason for revert: > This broke the Linux Oilpan Builder. > > Logs: http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/builds/13454/steps/compile/logs/stdio#error1 > > BUG=439604 > > Original issue's description: > > Implement unset value handling > > > > This patch accepts unset as a valid CSS value and creates > > a CSSUnsetValue object for it. Then when resolving it the > > rules stated in below link are implemented: > > > > http://dev.w3.org/csswg/css-cascade/#valuedef-unset > > > > Add a test for the new behavior. > > > > BUG=431689 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186604 > > TBR=timloh@chromium.org,rob.buis@samsung.com > NOTREECHECKS=true > NOTRY=true > BUG=431689 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186627 TBR=timloh@chromium.org,rob.buis@samsung.com NOTREECHECKS=true NOTRY=true BUG=439604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -2 lines) Patch
A LayoutTests/fast/css/unset-keyword.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/unset-keyword-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/css/CSSUnsetValue.h View 1 chunk +37 lines, -0 lines 0 comments Download
A Source/core/css/CSSUnsetValue.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 6 chunks +14 lines, -0 lines 0 comments Download
M Source/core/css/CSSValuePool.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSValuePool.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ilya Sherman
Created Revert of Revert of Implement unset value handling
6 years ago (2014-12-06 01:16:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773483003/1
6 years ago (2014-12-06 01:17:32 UTC) #2
commit-bot: I haz the power
6 years ago (2014-12-06 01:18:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186637

Powered by Google App Engine
This is Rietveld 408576698