Update mojo sdk to rev f6c8ec07c01deebc13178d516225fd12695c3dc2

Update mojo sdk to rev f6c8ec07c01deebc13178d516225fd12695c3dc2

BUG=None
TBR=digit@chromium.org for ashmem dep
TBR=darin@chromium.org for toplevel

Committed: https://crrev.com/fa648a32329c36eda94aeadac4aac14f3b8013be
Cr-Commit-Position: refs/heads/master@{#307427}

[Ken Rockot(use gerrit already), 2014-12-09 03:36:39]

rockot@chromium.org changed reviewers:
+ jamesr@chromium.org

[Ken Rockot(use gerrit already), 2014-12-09 03:38:13]

Patchset #2 (id:20001) has been deleted

[Ken Rockot(use gerrit already), 2014-12-09 03:40:12]

James, could you look at my ugly local hack to mojo_system_impl.gypi?

I don't understand why the component build fails on Android (linking
libmojo_system_impl) if the ashmem dependency is not expressed directly, but it
does.

[jamesr, 2014-12-09 04:22:55]

lgtm

https://codereview.chromium.org/782693004/diff/40001/mojo/edk/mojo_edk_system...
File mojo/edk/mojo_edk_system_impl.gypi (right):

https://codereview.chromium.org/782693004/diff/40001/mojo/edk/mojo_edk_system...
mojo/edk/mojo_edk_system_impl.gypi:122: 'conditions': [
i don't see what's strange or ugly about this -
mojo/edk/embedder/simple_platform_shared_buffer_android.cc uses ashmem so we
have to declare a dependency on it.  It's android-only because we only use it
from android specific files (and it's an android-only concept)

[Ken Rockot(use gerrit already), 2014-12-09 05:29:42]

On 2014/12/09 04:22:55, jamesr wrote:
> lgtm
> 
>
https://codereview.chromium.org/782693004/diff/40001/mojo/edk/mojo_edk_system...
> File mojo/edk/mojo_edk_system_impl.gypi (right):
> 
>
https://codereview.chromium.org/782693004/diff/40001/mojo/edk/mojo_edk_system...
> mojo/edk/mojo_edk_system_impl.gypi:122: 'conditions': [
> i don't see what's strange or ugly about this -
> mojo/edk/embedder/simple_platform_shared_buffer_android.cc uses ashmem so we
> have to declare a dependency on it.  It's android-only because we only use it
> from android specific files (and it's an android-only concept)

My confusion arises from the fact that we already have this dependency chain:

mojo_system_impl -> base -> ashmem

[Ken Rockot(use gerrit already), 2014-12-09 05:29:50]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-12-09 05:30:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782693004/40001

[commit-bot: I haz the power, 2014-12-09 05:38:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-09 05:38:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Rockot(use gerrit already), 2014-12-09 06:11:46]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-12-09 06:12:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/782693004/40001

[jamesr, 2014-12-09 06:20:02]

Indirect dependencies between components only "works" on the linux linker. On
Mac/win/android if component a uses symbols from component c it needs to declare
that on the link line for a regardless of any component b that might be in the
middle. The linker on linux allows unresolved symbols to stay unresolved all the
way up to run time.

[Ken Rockot(use gerrit already), 2014-12-09 06:24:21]

Ah, I've been living in a Linux bubble. Thanks for the explanation.

On Mon, Dec 8, 2014 at 10:20 PM, <jamesr@chromium.org> wrote:

> Indirect dependencies between components only "works" on the linux linker.
> On
> Mac/win/android if component a uses symbols from component c it needs to
> declare
> that on the link line for a regardless of any component b that might be in
> the
> middle. The linker on linux allows unresolved symbols to stay unresolved
> all the
> way up to run time.
>
> https://codereview.chromium.org/782693004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-12-09 06:41:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2014-12-09 06:42:33]

Patchset 2 (id:??) landed as
https://crrev.com/fa648a32329c36eda94aeadac4aac14f3b8013be
Cr-Commit-Position: refs/heads/master@{#307427}