Source/modules/serviceworkers/InstallEventInit.idl - Issue 780963004: Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/InstallEventInit.idl

Issue 780963004: Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushEventInit.idl ('K') | « Source/modules/serviceworkers/InstallEvent.idl ('k') | Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/InstallEventInit.idl

diff --git a/Source/modules/serviceworkers/RegistrationOptions.idl b/Source/modules/serviceworkers/InstallEventInit.idl

similarity index 58%

copy from Source/modules/serviceworkers/RegistrationOptions.idl

copy to Source/modules/serviceworkers/InstallEventInit.idl

index cdeda388e49264bc8737fdee2b8e7aea4655688b..16bb318439ceb4ae6a1608beee2215caac7957f4 100644

--- a/Source/modules/serviceworkers/RegistrationOptions.idl

+++ b/Source/modules/serviceworkers/InstallEventInit.idl

@@ -2,7 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#registration-option-list-dictionary

-dictionary RegistrationOptions {

- USVString scope = "/";

+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#install-event-interface

+dictionary InstallEventInit : ExtendableEventInit {

+ // FIXME: add following member.

+ // ServiceWorker activeWorker;

};