Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: Source/modules/push_messaging/PushEventInit.idl

Issue 780963004: Use event init dictionaries in modules/{notifications,push_messaging,serviceworkers} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushEventInit.idl
diff --git a/Source/modules/push_messaging/PushEventInit.idl b/Source/modules/push_messaging/PushEventInit.idl
new file mode 100644
index 0000000000000000000000000000000000000000..d7895442e1fabe063223c14eee9523f273aff951
--- /dev/null
+++ b/Source/modules/push_messaging/PushEventInit.idl
@@ -0,0 +1,11 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// https://w3c.github.io/push-api/#idl-def-PushEvent
+
+dictionary PushEventInit : ExtendableEventInit {
+ // FIXME: This should be PushMessageDataInit, which is a typedef of USVString
+ // https://w3c.github.io/push-api/#idl-def-PushMessageData
Peter Beverloo 2014/12/05 15:48:33 Could you remove this FIXME? The spec is wrong and
bashi 2014/12/08 23:39:29 Done. Thank you for the clarification :)
+ PushMessageData data;
+};

Powered by Google App Engine
This is Rietveld 408576698