Fix some closure compilation issues 8n order to update compiler.jar

Fix some closure compilation issues 8n order to update compiler.jar

R=fukino@chromium.org
BUG=78368
Committed: https://crrev.com/d6e3e9c982595dea42b1b4bffeb12f3f88fbd1a8
Cr-Commit-Position: refs/heads/master@{#307938}

[Dan Beam, 2014-12-04 04:54:53]

current issues:
https://gist.githubusercontent.com/danbeam/3485b5e3da03a3765b6d/raw/6a8a01404...

[fukino, 2014-12-04 05:02:28]

lgtm.

[Dan Beam, 2014-12-04 05:21:11]

now I just have to fix all the issues first, haha...

[fukino, 2014-12-04 05:33:45]

On 2014/12/04 05:21:11, Dan Beam wrote:
> now I just have to fix all the issues first, haha...

too much new issues... (typecheck for overriding function got strict?)
I'll land a fix for file manager, and if you don't have time, maybe I can make
CL for fix other issues.

[Dan Beam, 2014-12-11 00:09:45]

fukino@: can you take another look?  i've fixed everything but the createItem:
issues.  tbreisacher@ mentioned we could potentially templatize all these
classes but it just sounds like a ton of work

[Tyler Breisacher (Chromium), 2014-12-11 00:11:55]

On 2014/12/11 00:09:45, Dan Beam wrote:
> fukino@: can you take another look?  i've fixed everything but the createItem:
> issues.  tbreisacher@ mentioned we could potentially templatize all these
> classes but it just sounds like a ton of work

In general, if there is a tedious-sounding cleanup that you want to do, consider
using RefasterJS to do it. I suspect it wouldn't help in this particular case
though. https://github.com/google/closure-compiler/wiki/RefasterJS

[fukino, 2014-12-11 04:18:29]

On 2014/12/11 00:09:45, Dan Beam wrote:
> fukino@: can you take another look?  i've fixed everything but the createItem:
> issues.  tbreisacher@ mentioned we could potentially templatize all these
> classes but it just sounds like a ton of work

Thanks! lgtm.
Templatizing cr.ui.List (and cr.ui.ArrayDataModel?) sounds good to me to our
type check strict,
but, yes, it will be a huge CL...

[fukino, 2014-12-11 04:37:21]

On 2014/12/11 00:11:55, Tyler Breisacher (Chromium) wrote:
> On 2014/12/11 00:09:45, Dan Beam wrote:
> > fukino@: can you take another look?  i've fixed everything but the
createItem:
> > issues.  tbreisacher@ mentioned we could potentially templatize all these
> > classes but it just sounds like a ton of work
> 
> In general, if there is a tedious-sounding cleanup that you want to do,
consider
> using RefasterJS to do it. I suspect it wouldn't help in this particular case
> though. https://github.com/google/closure-compiler/wiki/RefasterJS

For now I'm not sure if we can use RefasterJS to templatizing existing classes,
but it looks convenient. I'll give it a try for refactoring. Thanks!

[Dan Beam, 2014-12-11 17:55:42]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-12-11 17:56:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780773002/60001

[commit-bot: I haz the power, 2014-12-11 18:48:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-11 18:50:46]

Patchset 4 (id:??) landed as
https://crrev.com/d6e3e9c982595dea42b1b4bffeb12f3f88fbd1a8
Cr-Commit-Position: refs/heads/master@{#307938}