Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: ui/webui/resources/js/cr/ui/controlled_indicator.js

Issue 780773002: Fix some closure compilation issues 8n order to update compiler.jar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: roll back *.jar Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/cr/ui/controlled_indicator.js
diff --git a/ui/webui/resources/js/cr/ui/controlled_indicator.js b/ui/webui/resources/js/cr/ui/controlled_indicator.js
index 110d6975165908617d9b4bd674ec44c0ca35b892..fbf8f171e498c7f7db26dbb60fe41c844e98b774 100644
--- a/ui/webui/resources/js/cr/ui/controlled_indicator.js
+++ b/ui/webui/resources/js/cr/ui/controlled_indicator.js
@@ -33,14 +33,8 @@ cr.define('cr.ui', function() {
},
/**
- * Shows an informational bubble displaying |content| and pointing at the
- * |target| element. If |content| has focusable elements, they join the
- * current page's tab order as siblings of |domSibling|.
+ * Shows an informational bubble displaying |content|.
* @param {HTMLDivElement} content The content of the bubble.
- * @param {HTMLElement} target The element at which the bubble points.
- * @param {HTMLElement} domSibling The element after which the bubble is
- * added to the DOM.
- * @param {cr.ui.ArrowLocation} location The arrow location.
*/
showBubble: function(content) {
this.hideBubble();
@@ -81,8 +75,8 @@ cr.define('cr.ui', function() {
if (this.hasAttribute('text' + this.controlledBy))
text = this.getAttribute('text' + this.controlledBy);
- else if (this.controlledBy == 'extension' && this.extensionName)
- text = defaultStrings.extensionWithName;
+ else if (this.controlledBy == 'extension' && this['extensionName'])
+ text = defaultStrings['extensionWithName'];
return text || '';
},
« no previous file with comments | « third_party/closure_compiler/externs/chrome_extensions.js ('k') | ui/webui/resources/js/cr/ui/expandable_bubble.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698