Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 780773002: Fix some closure compilation issues 8n order to update compiler.jar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: roll back *.jar Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index 78c9912b629381f11b1170e1d39995d8adb51f2f..3282e822db2d29e7bc6c1cdf4cb056b0889a19a6 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -24,7 +24,8 @@ cr.define('options.passwordManager', function() {
el.dataItem = entry;
el.dataModel = dataModel;
el.__proto__ = PasswordListItem.prototype;
- el.decorate(showPasswords);
+ el.showPasswords_ = showPasswords;
+ el.decorate();
return el;
}
@@ -33,7 +34,7 @@ cr.define('options.passwordManager', function() {
__proto__: DeletableItem.prototype,
/** @override */
- decorate: function(showPasswords) {
+ decorate: function() {
DeletableItem.prototype.decorate.call(this);
// The URL of the site.
@@ -69,12 +70,12 @@ cr.define('options.passwordManager', function() {
passwordInput.type = 'password';
passwordInput.className = 'inactive-password';
passwordInput.readOnly = true;
- passwordInput.value = showPasswords ? this.password : '********';
+ passwordInput.value = this.showPasswords_ ? this.password : '********';
passwordInputDiv.appendChild(passwordInput);
this.passwordField = passwordInput;
// The show/hide button.
- if (showPasswords) {
+ if (this.showPasswords_) {
var button = this.ownerDocument.createElement('button');
button.hidden = true;
button.className = 'list-inline-button custom-appearance';
@@ -313,7 +314,7 @@ cr.define('options.passwordManager', function() {
/**
* Create a new passwords list.
* @constructor
- * @extends {cr.ui.List}
+ * @extends {options.DeletableItemList}
*/
var PasswordExceptionsList = cr.ui.define('list');
« no previous file with comments | « chrome/browser/resources/options/editable_text_field.js ('k') | chrome/browser/resources/options/pref_ui.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698