DescriptionMake 'reload' in skydb work again
Looks like it broke with:
https://codereview.chromium.org/741453002
I don't really like this fix, (it just leaks
the SkyApplication object) but I don't have
a better one at the moment.
I suspect the problem may actually be in
ApplicationManager::LoadWithContentHandler
in its attempt to re-use connections, unclear.
The bug was that you would launch skydb and then
try to 'reload' the url and the reload would
be ignored every other attempt.
Reload just tells the view to embed the url
again. The ViewManager was telling its
client OnEmbed, but that message was never
arriving every other time. After many printfs
I traced this to the DocumentView being destroyed
(which calls SkyApplication::OnViewDestroyed)
and causing the SkyApplication to disappear
right before the ViewManager tried to talk to it.
R=aa@chromium.org
BUG=
Patch Set 1 #
Total comments: 1
Messages
Total messages: 7 (1 generated)
|