Make 'reload' in skydb work again

sky/viewer/content_handler_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/viewer/content_handler_impl.h"
 
 #include "base/bind.h"
 #include "mojo/public/cpp/application/connect.h"
 #include "mojo/services/public/interfaces/network/network_service.mojom.h"
 #include "sky/viewer/document_view.h"
@@ skipping 38 matching lines @@
           request.Pass(),
           base::Bind(&SkyApplication::OnResponseReceived,
                      base::Unretained(this), base::Passed(&loader),
                      base::Passed(&provider)));
     }
   }
 
  private:
   void OnViewDestroyed() {
     --view_count_;
-    if (view_count_ == 0) {
-      delete this;
-    }
+
+    // TODO(eseidel): We can't destroy ourselves synchronously here

[Aaron Boodman, 2014/12/05 23:29:50]

This seems like a reasonable fix for now. I don't think counting embeds is the
right way to manage app lifetime... but I don't think we know what the right way
is, either.

For more context, see:

https://codereview.chromium.org/776553003/diff/1/mojo/services/html_viewer/ht...
and 
https://groups.google.com/a/chromium.org/forum/#!topic/mojo-dev/d4G1y3d9zZc

+    // as we may be in the middle of a reload and doing so will cause
+    // ConnectionManager::EmbedAtView / ViewManagerServiceImpl::Init
+    // To end up sending the "AcceptConnection" to a dead SkyApplication
+    // (which will be silently ignored).  This manifests as every other
+    // "reload" command in skydb tearing down SkyApplication and silently
+    // failing.  Another alternative would be to post a task to check if we
+    // should delete ourselves.  We should likely keep ourselves alive
+    // so long as there is an active connection instead
+    // if (view_count_ == 0) {
+    //   delete this;
+    // }
   }
 
   void OnResponseReceived(mojo::URLLoaderPtr loader,
                           mojo::ServiceProviderPtr provider,
                           mojo::URLResponsePtr response) {
     new DocumentView(
         base::Bind(&SkyApplication::OnViewDestroyed, base::Unretained(this)),
         provider.Pass(), response.Pass(), shell_.get());
   }
 
   mojo::String url_;
   mojo::ShellPtr shell_;
   mojo::NetworkServicePtr network_service_;
   mojo::URLResponsePtr initial_response_;
   uint32_t view_count_;
 };
 
 ContentHandlerImpl::ContentHandlerImpl() {
 }
 
 ContentHandlerImpl::~ContentHandlerImpl() {
 }
 
 void ContentHandlerImpl::StartApplication(mojo::ShellPtr shell,
                                           mojo::URLResponsePtr response) {
   new SkyApplication(shell.Pass(), response.Pass());
 }
 
 }  // namespace sky