Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 783973002: Remove shutdown code from sky. (Closed)

Created:
6 years ago by qsr
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M sky/viewer/content_handler_impl.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M sky/viewer/document_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/viewer/document_view.cc View 1 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eseidel1
I'm happy to make it work instead of removing it But I'd like some guidance ...
6 years ago (2014-12-08 17:09:41 UTC) #2
Aaron Boodman
LGTM eseidel -- I think it makes sense to remove for now. https://codereview.chromium.org/783973002/diff/1/sky/viewer/document_view.cc File sky/viewer/document_view.cc ...
6 years ago (2014-12-08 18:33:33 UTC) #3
qsr
https://codereview.chromium.org/783973002/diff/1/sky/viewer/document_view.cc File sky/viewer/document_view.cc (right): https://codereview.chromium.org/783973002/diff/1/sky/viewer/document_view.cc#newcode244 sky/viewer/document_view.cc:244: delete this; On 2014/12/08 18:33:33, Aaron Boodman wrote: > ...
6 years ago (2014-12-09 09:59:58 UTC) #4
qsr
6 years ago (2014-12-09 10:00:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7f0531221d430b4a437b77e25897cc9ab089c57a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698