Don't key client auth on HttpNetworkSession.

Don't key client auth on HttpNetworkSession.

It's an IO-thread object being maintained (fortunately just as a pointer) on
the UI thread. It's used to tie together SSLClientAuthObserver instances, but
the BrowserContext is a more suitable UI thread key.

This relands part of https://codereview.chromium.org/596873002

BUG=439134
Committed: https://crrev.com/5b6ba9036b9583fcc0396d60eb441d92bead97ed
Cr-Commit-Position: refs/heads/master@{#307274}

[davidben, 2014-12-05 20:34:59]

davidben@chromium.org changed reviewers:
+ mmenke@chromium.org

[davidben, 2014-12-05 20:35:00]

Will add OWNERS after main review. This is one three parts of the original CL.
It's pretty easy to split off and almost entirely plumbing.

[mmenke, 2014-12-05 20:40:06]

On 2014/12/05 20:35:00, David Benjamin wrote:
> Will add OWNERS after main review. This is one three parts of the original CL.
> It's pretty easy to split off and almost entirely plumbing.

What was the crash that caused the CL to be reverted?

[davidben, 2014-12-05 20:45:49]

On 2014/12/05 20:40:06, mmenke wrote:
> On 2014/12/05 20:35:00, David Benjamin wrote:
> > Will add OWNERS after main review. This is one three parts of the original
CL.
> > It's pretty easy to split off and almost entirely plumbing.
> 
> What was the crash that caused the CL to be reverted?

The crash came from ClientCertStoreNSS (and equivalent code in
ClientCertStoreChromeOS):

https://code.google.com/p/chromium/codesearch#chromium/src/net/ssl/client_cer...

ClientCertStore assumes that the caller keeps the store alive while an
asynchronous operation is in progress. It's kept alive by virtue of the callback
holding a reference to SSLClientAuthHandler which owns the ClientCertStore. (Yay
circular ownership.) The unrefcounting portion of the original CL made that
callback own a WeakPtr and broke that. It shouldn't be too difficult a fix. We
just reverted it because it needed to merge to M40. In the meantime, I'm
splitting it up for easy of re-review.

[mmenke, 2014-12-05 21:02:52]

LGTM

[davidben, 2014-12-05 21:10:30]

davidben@chromium.org changed reviewers:
+ benm@chromium.org, sky@chromium.org

[davidben, 2014-12-05 21:10:31]

+sky,benm for chrome/ and android_webview/ OWNERS.

[sky, 2014-12-05 23:19:18]

On 2014/12/05 21:10:31, David Benjamin wrote:
> +sky,benm for chrome/ and android_webview/ OWNERS.

Please me more specific as to which files in chrome you need me to review
(sorry, I get a lot of reviews).

[davidben, 2014-12-05 23:25:14]

On 2014/12/05 23:19:18, sky wrote:
> On 2014/12/05 21:10:31, David Benjamin wrote:
> > +sky,benm for chrome/ and android_webview/ OWNERS.
> 
> Please me more specific as to which files in chrome you need me to review
> (sorry, I get a lot of reviews).

Oh, sorry. I actually don't have OWNERS coverage for anything under chrome/ in
this CL. It's mostly mechanical. mmenke did the main review.

It's also a reland of part of https://codereview.chromium.org/596873002; if it
would be better, I can toss this at jam instead since he reviewed the original
one.

[sky, 2014-12-05 23:58:34]

If this is mostly a reland please pass to the original reviewer.
Thanks!

On Fri, Dec 5, 2014 at 3:25 PM,  <davidben@chromium.org> wrote:
> On 2014/12/05 23:19:18, sky wrote:
>>
>> On 2014/12/05 21:10:31, David Benjamin wrote:
>> > +sky,benm for chrome/ and android_webview/ OWNERS.
>
>
>> Please me more specific as to which files in chrome you need me to review
>> (sorry, I get a lot of reviews).
>
>
> Oh, sorry. I actually don't have OWNERS coverage for anything under chrome/
> in
> this CL. It's mostly mechanical. mmenke did the main review.
>
> It's also a reland of part of https://codereview.chromium.org/596873002; if
> it
> would be better, I can toss this at jam instead since he reviewed the
> original
> one.
>
> https://codereview.chromium.org/780383002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[davidben, 2014-12-06 00:04:19]

davidben@chromium.org changed reviewers:
+ jam@chromium.org
- sky@chromium.org

[davidben, 2014-12-06 00:04:19]

+jam for chrome/ OWNERS. This is mostly a reland of a CL you looked at
previously and is fairly mechanical.

[sgurun-gerrit only, 2014-12-06 00:22:07]

On 2014/12/06 00:04:19, David Benjamin wrote:
> +jam for chrome/ OWNERS. This is mostly a reland of a CL you looked at
> previously and is fairly mechanical.

aw lgtm

[jam, 2014-12-06 00:34:09]

lgtm

[davidben, 2014-12-08 17:08:42]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-12-08 17:08:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/780383002/1

[commit-bot: I haz the power, 2014-12-08 17:55:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-08 17:56:05]

Patchset 1 (id:??) landed as
https://crrev.com/5b6ba9036b9583fcc0396d60eb441d92bead97ed
Cr-Commit-Position: refs/heads/master@{#307274}