chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm - Issue 780383002: Don't key client auth on HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

Issue 780383002: Don't key client auth on HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm ('k') | chrome/browser/ui/views/ssl_client_certificate_selector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

index 37757d62e14c59ec132386505b41911e78e93452..a0c71106e6692e7941e9f90ba3cd50fc2e7e4115 100644

--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm

@@ -50,7 +50,7 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, DISABLED_Basic) {

int count = 0;

SSLClientCertificateSelectorCocoa* selector =

[[SSLClientCertificateSelectorCocoa alloc]

- initWithNetworkSession:auth_requestor_->http_network_session_

+ initWithBrowserContext:web_contents->GetBrowserContext()

certRequestInfo:auth_requestor_->cert_request_info_.get()

callback:base::Bind(&OnCertificateSelected,

&cert,

@@ -72,13 +72,13 @@ IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, DISABLED_Basic) {

// Test that switching to another tab correctly hides the sheet.

IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorCocoaTest, HideShow) {

+ content::WebContents* web_contents =

+ browser()->tab_strip_model()->GetActiveWebContents();

SSLClientCertificateSelectorCocoa* selector =

[[SSLClientCertificateSelectorCocoa alloc]

- initWithNetworkSession:auth_requestor_->http_network_session_

+ initWithBrowserContext:web_contents->GetBrowserContext()

certRequestInfo:auth_requestor_->cert_request_info_.get()

callback:chrome::SelectCertificateCallback()];

- content::WebContents* web_contents =

- browser()->tab_strip_model()->GetActiveWebContents();

[selector displayForWebContents:web_contents];

content::RunAllPendingInMessageLoop();