Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3761)

Unified Diff: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm

Issue 780383002: Don't key client auth on HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
index 027b89671f778f243fba063ef8d30fbd67701ca6..9d471b923de6fe2903f327656efcdfd7df25dc2e 100644
--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
@@ -40,11 +40,11 @@ class SSLClientAuthObserverCocoaBridge : public SSLClientAuthObserver,
public ConstrainedWindowMacDelegate {
public:
SSLClientAuthObserverCocoaBridge(
- const net::HttpNetworkSession* network_session,
+ const content::BrowserContext* browser_context,
net::SSLCertRequestInfo* cert_request_info,
const chrome::SelectCertificateCallback& callback,
SSLClientCertificateSelectorCocoa* controller)
- : SSLClientAuthObserver(network_session, cert_request_info, callback),
+ : SSLClientAuthObserver(browser_context, cert_request_info, callback),
controller_(controller) {
}
@@ -71,14 +71,13 @@ namespace chrome {
void ShowSSLClientCertificateSelector(
content::WebContents* contents,
- const net::HttpNetworkSession* network_session,
net::SSLCertRequestInfo* cert_request_info,
const SelectCertificateCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// The dialog manages its own lifetime.
SSLClientCertificateSelectorCocoa* selector =
[[SSLClientCertificateSelectorCocoa alloc]
- initWithNetworkSession:network_session
+ initWithBrowserContext:contents->GetBrowserContext()
certRequestInfo:cert_request_info
callback:callback];
[selector displayForWebContents:contents];
@@ -88,14 +87,14 @@ void ShowSSLClientCertificateSelector(
@implementation SSLClientCertificateSelectorCocoa
-- (id)initWithNetworkSession:(const net::HttpNetworkSession*)networkSession
+- (id)initWithBrowserContext:(const content::BrowserContext*)browserContext
certRequestInfo:(net::SSLCertRequestInfo*)certRequestInfo
callback:(const chrome::SelectCertificateCallback&)callback {
- DCHECK(networkSession);
+ DCHECK(browserContext);
DCHECK(certRequestInfo);
if ((self = [super init])) {
observer_.reset(new SSLClientAuthObserverCocoaBridge(
- networkSession, certRequestInfo, callback, self));
+ browserContext, certRequestInfo, callback, self));
}
return self;
}

Powered by Google App Engine
This is Rietveld 408576698